From fb50cdfeeda868ae2bfe7ec2e0afebff53eca2d5 Mon Sep 17 00:00:00 2001 From: William Breathitt Gray Date: Sun, 22 Nov 2015 11:38:55 -0500 Subject: [PATCH] gpio: 104-idio-16: Disable IRQ on device probe IRQ should be disabled on device probe so that the device IRQ is in a known starting state. If IRQ is not disabled, interrupts may be reported as handled by the IRQ handler, despite no irq_unmask calls made by the user. Signed-off-by: William Breathitt Gray Signed-off-by: Linus Walleij --- drivers/gpio/gpio-104-idio-16.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio-16.c index 81b6904bdfe6..efe3ff7d574e 100644 --- a/drivers/gpio/gpio-104-idio-16.c +++ b/drivers/gpio/gpio-104-idio-16.c @@ -242,6 +242,9 @@ static int __init idio_16_probe(struct platform_device *pdev) goto err_gpio_register; } + /* Disable IRQ by default */ + outb(0, base + 2); + err = gpiochip_irqchip_add(&idio16gpio->chip, &idio_16_irqchip, 0, handle_edge_irq, IRQ_TYPE_NONE); if (err) { -- 2.39.5