From fd5e2fd053e1042b12343fb6649449081ec1bab4 Mon Sep 17 00:00:00 2001 From: kbuild test robot Date: Fri, 1 May 2015 00:21:55 +0800 Subject: [PATCH] staging: lustre: llite: fix ifnullfree.cocci warnings drivers/staging/lustre/lustre/llite/dir.c:1440:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Julia Lawall Signed-off-by: Fengguang Wu Signed-off-by: Greg Kroah-Hartman --- drivers/staging/lustre/lustre/llite/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c index 0f5d57cb149a..f17154aaa329 100644 --- a/drivers/staging/lustre/lustre/llite/dir.c +++ b/drivers/staging/lustre/lustre/llite/dir.c @@ -1436,8 +1436,7 @@ lmv_out_free: goto free_lmv; } free_lmv: - if (tmp) - kfree(tmp); + kfree(tmp); return rc; } case LL_IOC_REMOVE_ENTRY: { -- 2.39.5