From fdfd9d1b8912991d88fc29a456867c62515218f9 Mon Sep 17 00:00:00 2001 From: Maciej Trela Date: Fri, 13 Jan 2012 21:52:38 +0000 Subject: [PATCH] [SCSI] libsas: kill spurious sas_put_device Holdover from a patch rework, prior to the addition of SAS_DEV_DESTROY we were holding a reference while the destruct was pending in case the domain was torn down before the desctruct event ran. That case is covered by SAS_DEV_DESTROY, and the sas_put_device() just corrupts freed memory, or worse frees the memory while another agent holds a reference. Signed-off-by: Maciej Trela Signed-off-by: Dan Williams Signed-off-by: James Bottomley --- drivers/scsi/libsas/sas_discover.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c index 4be5ddad7be7..c1ac99d25f5e 100644 --- a/drivers/scsi/libsas/sas_discover.c +++ b/drivers/scsi/libsas/sas_discover.c @@ -281,8 +281,6 @@ static void sas_destruct_devices(struct work_struct *work) sas_rphy_delete(dev->rphy); dev->rphy = NULL; sas_unregister_common_dev(port, dev); - - sas_put_device(dev); } } -- 2.39.5