From fe2252e914ca4cf0c8ae1c5e493cc2e0a5a77a3c Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Wed, 20 Feb 2013 13:15:46 +1100 Subject: [PATCH] rtc-add-support-for-spi-rtc-rx4581-checkpatch-fixes WARNING: quoted string split across lines #171: FILE: drivers/rtc/rtc-rx4581.c:126: + dev_err(dev, "Unable to write device " + "flags\n"); WARNING: quoted string split across lines #214: FILE: drivers/rtc/rtc-rx4581.c:169: + dev_dbg(dev, "%s: tm is secs=%d, mins=%d, hours=%d, " + "mday=%d, mon=%d, year=%d, wday=%d\n", WARNING: quoted string split across lines #233: FILE: drivers/rtc/rtc-rx4581.c:188: + dev_dbg(dev, "%s: secs=%d, mins=%d, hours=%d, " + "mday=%d, mon=%d, year=%d, wday=%d\n", WARNING: Using __devinit is unnecessary #310: FILE: drivers/rtc/rtc-rx4581.c:265: +static int __devinit rx4581_probe(struct spi_device *spi) WARNING: Using __devexit is unnecessary #329: FILE: drivers/rtc/rtc-rx4581.c:284: +static int __devexit rx4581_remove(struct spi_device *spi) WARNING: space prohibited between function name and open parenthesis '(' #355: FILE: drivers/rtc/rtc-rx4581.c:310: +MODULE_DESCRIPTION ("rx4581 spi RTC driver"); WARNING: space prohibited between function name and open parenthesis '(' #356: FILE: drivers/rtc/rtc-rx4581.c:311: +MODULE_AUTHOR ("Torben Hohn"); WARNING: space prohibited between function name and open parenthesis '(' #357: FILE: drivers/rtc/rtc-rx4581.c:312: +MODULE_LICENSE ("GPL"); total: 0 errors, 8 warnings, 334 lines checked ./patches/rtc-add-support-for-spi-rtc-rx4581.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Torben Hohn Signed-off-by: Andrew Morton --- drivers/rtc/rtc-rx4581.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-rx4581.c b/drivers/rtc/rtc-rx4581.c index 62d375e6a519..421e08baa17d 100644 --- a/drivers/rtc/rtc-rx4581.c +++ b/drivers/rtc/rtc-rx4581.c @@ -262,7 +262,7 @@ static const struct rtc_class_ops rx4581_rtc_ops = { .set_time = rx4581_set_datetime, }; -static int __devinit rx4581_probe(struct spi_device *spi) +static int rx4581_probe(struct spi_device *spi) { struct rtc_device *rtc; unsigned char tmp; @@ -281,7 +281,7 @@ static int __devinit rx4581_probe(struct spi_device *spi) return 0; } -static int __devexit rx4581_remove(struct spi_device *spi) +static int rx4581_remove(struct spi_device *spi) { struct rtc_device *rtc = dev_get_drvdata(&spi->dev); @@ -307,7 +307,7 @@ static struct spi_driver rx4581_driver = { module_spi_driver(rx4581_driver); -MODULE_DESCRIPTION ("rx4581 spi RTC driver"); -MODULE_AUTHOR ("Torben Hohn"); -MODULE_LICENSE ("GPL"); +MODULE_DESCRIPTION("rx4581 spi RTC driver"); +MODULE_AUTHOR("Torben Hohn"); +MODULE_LICENSE("GPL"); MODULE_ALIAS("spi:rtc-rx4581"); -- 2.39.5