]> git.karo-electronics.de Git - karo-tx-linux.git/commit
USB: EHCI: unlink unused QHs when the controller is stopped
authorAlan Stern <stern@rowland.harvard.edu>
Tue, 5 Apr 2011 17:36:15 +0000 (13:36 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 21 Apr 2011 21:32:56 +0000 (14:32 -0700)
commit05cf278c7141fd2a4373e62161416e85aeb688bc
tree4b873e7acb126a4e1204c829c10198d718194c34
parentc0cc35919317b579b23514c1385f246f348852ad
USB: EHCI: unlink unused QHs when the controller is stopped

commit 94ae4976e253757e9b03a44d27d41b20f1829d80 upstream.

This patch (as1458) fixes a problem affecting ultra-reliable systems:
When hardware failover of an EHCI controller occurs, the data
structures do not get released correctly.  This is because the routine
responsible for removing unused QHs from the async schedule assumes
the controller is running properly (the frame counter is used in
determining how long the QH has been idle) -- but when a failover
causes the controller to be electronically disconnected from the PCI
bus, obviously it stops running.

The solution is simple: Allow scan_async() to remove a QH from the
async schedule if it has been idle for long enough _or_ if the
controller is stopped.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-and-Tested-by: Dan Duval <dan.duval@stratus.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/ehci-q.c