]> git.karo-electronics.de Git - karo-tx-linux.git/commit
V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 5 Jan 2012 05:27:57 +0000 (02:27 -0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 26 Jan 2012 01:24:46 +0000 (17:24 -0800)
commit065449fd56d2f75cc943a6d501b292f6b0e40325
tree944eb13b6e59e29869631a30e27460249524a572
parentb1830247c9927d7d2ca17c9f84908fc130051792
V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy()

commit 6c06108be53ca5e94d8b0e93883d534dd9079646 upstream.

If ctrls->count is too high the multiplication could overflow and
array_size would be lower than expected.  Mauro and Hans Verkuil
suggested that we cap it at 1024.  That comes from the maximum
number of controls with lots of room for expantion.

$ grep V4L2_CID include/linux/videodev2.h | wc -l
211

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/media/video/v4l2-ioctl.c
include/linux/videodev2.h