]> git.karo-electronics.de Git - karo-tx-linux.git/commit
HID: intel-ish-hid: add printf attribute to print_log()
authorNicolas Iooss <nicolas.iooss_linux@m4x.org>
Thu, 22 Dec 2016 10:09:09 +0000 (11:09 +0100)
committerJiri Kosina <jkosina@suse.cz>
Mon, 2 Jan 2017 12:16:32 +0000 (13:16 +0100)
commit0aae34fa314d7dedfe756ab81787df7944de0df6
tree6f7be04312b6e85f8f3af2b794c55273967c857c
parentf39fdf2ab846ecc636d6272b47f28a05a2052a14
HID: intel-ish-hid: add printf attribute to print_log()

Structure ishtp_device contains a logging function, print_log(), which
formats some of its parameters using vsnprintf(). Add a __printf
attribute to this function field (and to ish_event_tracer()) in order to
detect at compile time issues related to the printf-like formatting.

While at it, make format parameter a const pointer as print_log() is not
supposed to modify it.

Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/intel-ish-hid/ipc/pci-ish.c
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h