]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sysctl: fix null checking in bin_dn_node_address()
authorXi Wang <xi.wang@gmail.com>
Thu, 28 Feb 2013 01:05:21 +0000 (17:05 -0800)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 6 Mar 2013 03:24:17 +0000 (03:24 +0000)
commit0ba15a927d8cf09cab753066736c87831a735987
treedde397db1e5baac6e7327686cc35670457c7b673
parenta2a9af6cffebedfbbe70081157096826ff4eef9a
sysctl: fix null checking in bin_dn_node_address()

commit df1778be1a33edffa51d094eeda87c858ded6560 upstream.

The null check of `strchr() + 1' is broken, which is always non-null,
leading to OOB read.  Instead, check the result of strchr().

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
kernel/sysctl_binary.c