]> git.karo-electronics.de Git - karo-tx-linux.git/commit
iio: adc: meson-saradc: fix potential crash in meson_sar_adc_clear_fifo
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Sun, 4 Jun 2017 13:28:23 +0000 (15:28 +0200)
committerJonathan Cameron <jic23@kernel.org>
Sun, 11 Jun 2017 14:00:13 +0000 (15:00 +0100)
commit103a07d4278203d6299798cd74cdc4d209801cac
tree462b39551218c6aac93c12f7e521e28a076b596d
parent1454e15bc28ba94aa5d6b31a83a42d5c03af2a6d
iio: adc: meson-saradc: fix potential crash in meson_sar_adc_clear_fifo

meson_sar_adc_clear_fifo passes a 0 as value-pointer to regmap_read().
In case of the meson-saradc driver this ends up in regmap_mmio_read(),
where the value-pointer is de-referenced unconditionally to assign the
value which was read.
Fix this by passing an actual pointer, even though all we want to do is
to discard the value.

As a side-effect this fixes a sparse warning ("Using plain integer as
NULL pointer") as reported by Paolo Cretaro.

Fixes: 3adbf3427330 ("iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs")
Reported-by: Paolo Cretaro <paolocretaro@gmail.com>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/adc/meson_saradc.c