]> git.karo-electronics.de Git - karo-tx-linux.git/commit
filter: fix sk_filter rcu handling
authorEric Dumazet <eric.dumazet@gmail.com>
Mon, 6 Dec 2010 17:29:43 +0000 (09:29 -0800)
committerAK <andi@firstfloor.org>
Sun, 6 Feb 2011 19:03:38 +0000 (11:03 -0800)
commit10cac669d7b9bad2207c2d63619fb265f8cb6486
tree48989da7c82f5f82c3abb7e68a77391a10d9650c
parent9b8a00c1f467735fbead2228f331a1182c9bb643
filter: fix sk_filter rcu handling

[ Upstream commit 46bcf14f44d8f31ecfdc8b6708ec15a3b33316d9 ]

Pavel Emelyanov tried to fix a race between sk_filter_(de|at)tach and
sk_clone() in commit 47e958eac280c263397

Problem is we can have several clones sharing a common sk_filter, and
these clones might want to sk_filter_attach() their own filters at the
same time, and can overwrite old_filter->rcu, corrupting RCU queues.

We can not use filter->rcu without being sure no other thread could do
the same thing.

Switch code to a more conventional ref-counting technique : Do the
atomic decrement immediately and queue one rcu call back when last
reference is released.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
include/net/sock.h
net/core/filter.c