]> git.karo-electronics.de Git - karo-tx-linux.git/commit
scsi: sg: fix static checker warning in sg_is_valid_dxfer
authorJohannes Thumshirn <jthumshirn@suse.de>
Mon, 17 Jul 2017 13:11:42 +0000 (15:11 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 18 Jul 2017 03:03:48 +0000 (23:03 -0400)
commit14074aba4bcda3764c9a702b276308b89901d5b6
treee5ecc2155d58096e0b960287b13c1a3d1472bafd
parenteeee4107546ef24c739d72645899e50fa693e9ff
scsi: sg: fix static checker warning in sg_is_valid_dxfer

dxfer_len is an unsigned int and we always assign a value > 0 to it, so
it doesn't make any sense to check if it is < 0. We can't really check
dxferp as well as we have both NULL and not NULL cases in the possible
call paths.

So just return true for SG_DXFER_FROM_DEV transfer in
sg_is_valid_dxfer().

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reported-by: Colin Ian King <colin.king@canonical.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sg.c