]> git.karo-electronics.de Git - karo-tx-linux.git/commit
pkt_sched: fix virtual-start-time update in QFQ
authorPaolo Valente <paolo.valente@unimore.it>
Sat, 15 Sep 2012 00:41:35 +0000 (00:41 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 10 Oct 2012 02:31:27 +0000 (03:31 +0100)
commit1876912a61291c434ab89996200297af5cdcd4ac
treeba04ba910ec2a5c235fcedfa1f8ac286e2dff7cd
parent50d09c3beecd0380910cfad192943d05d83edbf3
pkt_sched: fix virtual-start-time update in QFQ

[ Upstream commit 71261956973ba9e0637848a5adb4a5819b4bae83 ]

If the old timestamps of a class, say cl, are stale when the class
becomes active, then QFQ may assign to cl a much higher start time
than the maximum value allowed. This may happen when QFQ assigns to
the start time of cl the finish time of a group whose classes are
characterized by a higher value of the ratio
max_class_pkt/weight_of_the_class with respect to that of
cl. Inserting a class with a too high start time into the bucket list
corrupts the data structure and may eventually lead to crashes.
This patch limits the maximum start time assigned to a class.

Signed-off-by: Paolo Valente <paolo.valente@unimore.it>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/sched/sch_qfq.c