]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sparc64: Fix buggy strlcpy() conversion in ldom_reboot().
authorDavid S. Miller <davem@davemloft.net>
Fri, 27 Sep 2013 20:46:04 +0000 (13:46 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Sep 2013 20:46:04 +0000 (13:46 -0700)
commit2bd161a605f1f84a5fc8a4fe8410113a94f79355
tree2a5bdbe12f328d0bbb7345a61aa35ca4916bb021
parent6cac446bd37d9381815fe4c2b0e7b1fd1085000c
sparc64: Fix buggy strlcpy() conversion in ldom_reboot().

Commit 117a0c5fc9c2d06045bd217385b2b39ea426b5a6 ("sparc: kernel: using
strlcpy() instead of strcpy()") added a bug to ldom_reboot in
arch/sparc/kernel/ds.c

- strcpy(full_boot_str + strlen("boot "), boot_command);
+      strlcpy(full_boot_str + strlen("boot "), boot_command,
+            sizeof(full_boot_str + strlen("boot ")));

That last sizeof() expression evaluates to sizeof(size_t) which is
not what was intended.

Also even the corrected:

     sizeof(full_boot_str) + strlen("boot ")

is not right as the destination buffer length is just plain
"sizeof(full_boot_str)" and that's what the final argument
should be.

Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc/kernel/ds.c