]> git.karo-electronics.de Git - karo-tx-linux.git/commit
staging: comedi: dt282x: dt282x_ai_insn_read() always fails
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 20 Aug 2013 08:57:35 +0000 (11:57 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Aug 2013 17:07:17 +0000 (10:07 -0700)
commit2c4283ca7cdcc6605859c836fc536fcd83a4525f
tree7d7ea96487cd7dcba0fba4bec50757262b3f5133
parentded82ef91e247692682d696462f5f7e1f528758c
staging: comedi: dt282x: dt282x_ai_insn_read() always fails

In dt282x_ai_insn_read() we call this macro like:
wait_for(!mux_busy(), comedi_error(dev, "timeout\n"); return -ETIME;);
Because the if statement doesn't have curly braces it means we always
return -ETIME and the function never succeeds.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Cc: stable <stable@vger.kernel.org> # 2.6.36+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dt282x.c