]> git.karo-electronics.de Git - karo-tx-linux.git/commit
kdb: Fix handling of kallsyms_symbol_next() return value
authorDaniel Thompson <daniel.thompson@linaro.org>
Mon, 2 Mar 2015 14:13:36 +0000 (14:13 +0000)
committerJason Wessel <jason.wessel@windriver.com>
Tue, 3 Mar 2015 03:25:09 +0000 (21:25 -0600)
commit2d289f14f00a0da6bae7c8415fc8dd9d030458b8
treede98b2fc1fc0c28f42d3661f6b5ecd77940f7e16
parentc517d838eb7d07bbe9507871fab3931deccff539
kdb: Fix handling of kallsyms_symbol_next() return value

kallsyms_symbol_next() returns a boolean (true on success). Currently
kdb_read() tests the return value with an inequality that
unconditionally evaluates to true.

This is fixed in the obvious way and, since the conditional branch is
supposed to be unreachable, we also add a WARN_ON().

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
kernel/debug/kdb/kdb_io.c