]> git.karo-electronics.de Git - karo-tx-linux.git/commit
v4l1: fix 32-bit compat microcode loading translation
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 15 Oct 2010 18:12:38 +0000 (11:12 -0700)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Thu, 6 Jan 2011 23:08:09 +0000 (18:08 -0500)
commit3376769041fc2e51e05db869e2aab0c77e975982
tree728338c9fb5773d160c1ea1f60e68086f067fe65
parent629ccc0f02ff1ce098c5dcb99e88f656b1162db9
v4l1: fix 32-bit compat microcode loading translation

commit 3e645d6b485446c54c6745c5e2cf5c528fe4deec upstream.

The compat code for the VIDIOCSMICROCODE ioctl is totally buggered.
It's only used by the VIDEO_STRADIS driver, and that one is scheduled to
staging and eventually removed unless somebody steps up to maintain it
(at which point it should use request_firmware() rather than some magic
ioctl).  So we'll get rid of it eventually.

But in the meantime, the compatibility ioctl code is broken, and this
tries to get it to at least limp along (even if Mauro suggested just
deleting it entirely, which may be the right thing to do - I don't think
the compatibility translation code has ever worked unless you were very
lucky).

Reported-by: Kees Cook <kees.cook@canonical.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
drivers/media/video/v4l2-compat-ioctl32.c