]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x86, early_ioremap: fix fencepost error
authorAlan Cox <alan@redhat.com>
Sun, 12 Oct 2008 19:40:08 +0000 (19:40 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 22 Oct 2008 21:05:13 +0000 (14:05 -0700)
commit3762d1c86c1e862603f4c86cbd962475b5747865
tree6dc9f8bf64bbe191c39da0500044d806f0b59b10
parent75402d996fe1fe834ce1d1ed5d600407b23a8713
x86, early_ioremap: fix fencepost error

commit c613ec1a7ff3714da11c7c48a13bab03beb5c376 upstream

The x86 implementation of early_ioremap has an off by one error. If we get
an object which ends on the first byte of a page we undermap by one page and
this causes a crash on boot with the ASUS P5QL whose DMI table happens to fit
this alignment.

The size computation is currently

last_addr = phys_addr + size - 1;
npages = (PAGE_ALIGN(last_addr) - phys_addr)

(Consider a request for 1 byte at alignment 0...)

Closes #11693

Debugging work by Ian Campbell/Felix Geyer

Signed-off-by: Alan Cox <alan@rehat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86/mm/ioremap.c