]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net/fec_mpc52xx: Fix kernel panic on FEC error
authorJohn Bonesio <bones@secretlab.ca>
Wed, 14 Oct 2009 22:10:19 +0000 (15:10 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 14 Oct 2009 22:10:19 +0000 (15:10 -0700)
commit37ccd92f55c6c6c23f2b4a7c8830b313b70da0ed
treec2dd58c451a5923011fbfd1b8beea67b6077f766
parente72701acbe0b35e52d3f04d442837c06b4e64f1c
net/fec_mpc52xx: Fix kernel panic on FEC error

The MDIO bus cannot be accessed at interrupt context, but on an FEC
error, the fec_mpc52xx driver reset function also tries to reset the
PHY.  Since the error is detected at IRQ context, and the PHY functions
try to sleep, the kernel ends up panicking.

Resetting the PHY on an FEC error isn't even necessary.  This patch
solves the problem by removing the PHY reset entirely.

Signed-off-by: John Bonesio <bones@secretlab.ca>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/fec_mpc52xx.c