]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/i915: Nuke skl_update_plane debug message from the pipe update critical section
authorMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Wed, 8 Mar 2017 12:00:07 +0000 (13:00 +0100)
committerJani Nikula <jani.nikula@intel.com>
Mon, 13 Mar 2017 15:30:26 +0000 (17:30 +0200)
commit3a0d137de035cc8c70194d9988ded61825b5ff8a
tree4640f6029dfeca7c98cc33585647ac1bb69afe65
parentaac66bf5f916f645bd57029490a72c3f91f2c274
drm/i915: Nuke skl_update_plane debug message from the pipe update critical section

printks are slow so we should not be doing them from the vblank evade
critical section. These could explain why we sometimes seem to
blow past our 100 usec deadline.

The problem has been there ever since commit c331879ce8ea ("drm/i915:
skylake sprite plane scaling using shared scalers.") but it may not have
been readily visible until commit e1edbd44e23b ("drm/i915: Complain
if we take too long under vblank evasion.") increased our chances
of noticing it.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1488974407-25175-1-git-send-email-maarten.lankhorst@linux.intel.com
Fixes: c331879ce8ea ("drm/i915: skylake sprite plane scaling using shared scalers")
Cc: <stable@vger.kernel.org> # v4.2+
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
[mlankhorst: Add missing tags, point to the correct offending commit]
(cherry picked from commit d38146b9ee16264ff9a88bf3391ab9f2f5af3646)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_sprite.c