]> git.karo-electronics.de Git - karo-tx-linux.git/commit
signal: move the "sig < SIGRTMIN" check into siginmask(sig)
authorOleg Nesterov <oleg@redhat.com>
Mon, 23 May 2016 23:24:02 +0000 (16:24 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 24 May 2016 00:04:14 +0000 (17:04 -0700)
commit5c8ccefdf46c5f87d87b694c7fbc04941c2c99a5
treed2115adcef5c635ba4698c25a89934f7ff15e8e4
parent747800efbe8b98459f48d1d9d742298f8283f8fa
signal: move the "sig < SIGRTMIN" check into siginmask(sig)

All the users of siginmask() must ensure that sig < SIGRTMIN.  sig_fatal()
doesn't and this is wrong:

UBSAN: Undefined behaviour in kernel/signal.c:911:6
shift exponent 32 is too large for 32-bit type 'long unsigned int'

the patch doesn't add the neccesary check to sig_fatal(), it moves the
check into siginmask() and updates other callers.

Link: http://lkml.kernel.org/r/20160517195052.GA15187@redhat.com
Reported-by: Meelis Roos <mroos@linux.ee>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/signal.h