]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[PATCH] PPTP helper: Fix endianness bug in GRE key / CallID NAT
authorHarald Welte <laforge@netfilter.org>
Tue, 15 Nov 2005 12:32:36 +0000 (13:32 +0100)
committerChris Wright <chrisw@osdl.org>
Thu, 24 Nov 2005 22:10:08 +0000 (14:10 -0800)
commit63cb535137220bc764b2c6def34843acb53e99f3
treed01688e4d886a5c7d848a3f3d972c9eb66db4e35
parente193ed753d6f1301a06b797e512e01e3c569fec8
[PATCH] PPTP helper: Fix endianness bug in GRE key / CallID NAT

This endianness bug slipped through while changing the 'gre.key' field in
the conntrack tuple from 32bit to 16bit.

None of my tests caught the problem, since the linux pptp client always has
'0' as call id / gre key.  Only windows clients actually trigger the bug.

Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: Chris Wright <chrisw@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ipv4/netfilter/ip_nat_proto_gre.c