]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ARM: EXYNOS: Properly skip unitialized parent clock in power domain on
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Fri, 22 Apr 2016 07:26:52 +0000 (09:26 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 May 2016 09:21:14 +0000 (11:21 +0200)
commit63e9a60f4357e700a181980d424ffeaff32d5340
treec49a1881fccde128f24f9d29c54e811a67a2ba54
parent851375cc493de34a1443d85c46b026d8aeda715a
ARM: EXYNOS: Properly skip unitialized parent clock in power domain on

commit a0a966b83873f33778710a4fc59240244b0734a5 upstream.

We want to skip reparenting a clock on turning on power domain, if we
do not have the parent yet. The parent is obtained when turning the
domain off. However due to a typo, the loop is continued on IS_ERR() of
clock being reparented, not on the IS_ERR() of the parent.

Theoretically this could lead to OOPS on first turn on of a power
domain, if there was no turn off before. Practically that should never
happen because all power domains are turned on by default (reset value,
bootloader does not turn off them usually) so the first action will be
always turn off.

Fixes: 29e5eea06bc1 ("ARM: EXYNOS: Get current parent clock for power domain on/off")
Reported-by: Vladimir Zapolskiy <vz@mleia.com>
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm/mach-exynos/pm_domains.c