]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[media] am437x-vpfe: always assign bpp variable
authorNicolas Iooss <nicolas.iooss_linux@m4x.org>
Tue, 27 Dec 2016 18:02:36 +0000 (16:02 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 30 Jan 2017 17:43:40 +0000 (15:43 -0200)
commit6ebf75774f823ddbdbd10921006989d4df222f4a
tree760bc08baeaa9a9f7141a8fc39909b249fd84af6
parent05a89739e9f537855b02f5756ca04b7c77f1e9aa
[media] am437x-vpfe: always assign bpp variable

In vpfe_s_fmt(), when the sensor format and the requested format were
the same, bpp was assigned to vpfe->bpp without being initialized first.

Grab the bpp value that is currently used by using __vpfe_get_format()
instead of its wrapper, vpfe_try_fmt().

This use of uninitialized variable has been found by compiling the
kernel with clang.

Fixes: 417d2e507edc ("[media] media: platform: add VPFE capture driver
support for AM437X")

Cc: stable@vger.kernel.org
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/am437x/am437x-vpfe.c