]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Btrfs: move kobj stuff out of dev_replace lock range
authorLiu Bo <bo.li.liu@oracle.com>
Fri, 14 Aug 2015 10:33:07 +0000 (18:33 +0800)
committerDavid Sterba <dsterba@suse.com>
Thu, 1 Oct 2015 16:07:59 +0000 (18:07 +0200)
commit73416dab235e5ff030e3b3c61da0cd6ced324fc9
treeeacb4410f3b1e79be065d826cc7894441fafc3c1
parentf190aa471a7a703444f6587ed79c24a04a22d848
Btrfs: move kobj stuff out of dev_replace lock range

To avoid deadlock described in commit 084b6e7c7607 ("btrfs: Fix a
lockdep warning when running xfstest."), we should move kobj stuff out
of dev_replace lock range.

  "It is because the btrfs_kobj_{add/rm}_device() will call memory
  allocation with GFP_KERNEL,
  which may flush fs page cache to free space, waiting for it self to do
  the commit, causing the deadlock.

  To solve the problem, move btrfs_kobj_{add/rm}_device() out of the
  dev_replace lock range, also involing split the
  btrfs_rm_dev_replace_srcdev() function into remove and free parts.

  Now only btrfs_rm_dev_replace_remove_srcdev() is called in dev_replace
  lock range, and kobj_{add/rm} and btrfs_rm_dev_replace_free_srcdev() are
  called out of the lock range."

Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: Anand Jain <anand.jain@oracle.com>
[added lockup description]
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/dev-replace.c