]> git.karo-electronics.de Git - karo-tx-linux.git/commit
libfs: Modify mount_pseudo_xattr to be clear it is not a userspace mount
authorEric W. Biederman <ebiederm@xmission.com>
Wed, 4 Jan 2017 04:37:27 +0000 (17:37 +1300)
committerEric W. Biederman <ebiederm@xmission.com>
Tue, 10 Jan 2017 00:34:55 +0000 (13:34 +1300)
commit75422726b0f717d67db3283c2eb5bc14fa2619c5
tree166111b615cc1e00e809eff6186146e09785c524
parent3895dbf8985f656675b5bde610723a29cbce3fa7
libfs: Modify mount_pseudo_xattr to be clear it is not a userspace mount

Add MS_KERNMOUNT to the flags that are passed.
Use sget_userns and force &init_user_ns instead of calling sget so that
even if called from a weird context the internal filesystem will be
considered to be in the intial user namespace.

Luis Ressel reported that the the failure to pass MS_KERNMOUNT into
mount_pseudo broke his in development graphics driver that uses the
generic drm infrastructure.  I am not certain the deriver was bug
free in it's usage of that infrastructure but since
mount_pseudo_xattr can never be triggered by userspace it is clearer
and less error prone, and less problematic for the code to be explicit.

Reported-by: Luis Ressel <aranea@aixah.de>
Tested-by: Luis Ressel <aranea@aixah.de>
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
fs/libfs.c