]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net: Fix a memmove bug in dev_gro_receive()
authorJarek Poplawski <jarkao2@gmail.com>
Wed, 11 Aug 2010 02:02:10 +0000 (02:02 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 26 Aug 2010 23:43:47 +0000 (16:43 -0700)
commit7abab52d26329d2e0fe97a12560e6ba44ebe4eff
tree4b037c64bc4ef8922a7277ca8f495e775e27e3b0
parent700aaacee609d03b9c790206468340661e8a908d
net: Fix a memmove bug in dev_gro_receive()

[ Upstream commit e5093aec2e6b60c3df2420057ffab9ed4a6d2792 ]

>Xin Xiaohui wrote:
> I looked into the code dev_gro_receive(), found the code here:
> if the frags[0] is pulled to 0, then the page will be released,
> and memmove() frags left.
> Is that right? I'm not sure if memmove do right or not, but
> frags[0].size is never set after memove at least. what I think
> a simple way is not to do anything if we found frags[0].size == 0.
> The patch is as followed.
...

This version of the patch fixes the bug directly in memmove.

Reported-by: "Xin, Xiaohui" <xiaohui.xin@intel.com>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/core/dev.c