]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sched/fair: Avoid integer overflow
authorMichal Nazarewicz <mina86@mina86.com>
Sun, 10 Nov 2013 19:42:01 +0000 (20:42 +0100)
committerIngo Molnar <mingo@kernel.org>
Wed, 13 Nov 2013 12:33:55 +0000 (13:33 +0100)
commit85b088e934b9943322bfe37077289ae60f1b3414
tree2ad7a5376ecf31e10604794f98c8e8c63e42aeca
parent911b2898b3c9fe0048e9485ad1629ed4fce330fd
sched/fair: Avoid integer overflow

sa->runnable_avg_sum is of type u32 but after shifting it by NICE_0_SHIFT
bits it is promoted to u64.  This of course makes no sense, since the
result will never be more then 32-bit long.  Casting sa->runnable_avg_sum
to u64 before it is shifted, fixes this problem.

Reviewed-by: Ben Segall <bsegall@google.com>
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1384112521-25177-1-git-send-email-mpn@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/fair.c