]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ALSA: core: Fix unexpected error at replacing user TLV
authorTakashi Iwai <tiwai@suse.de>
Tue, 22 Aug 2017 06:15:13 +0000 (08:15 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 22 Aug 2017 13:43:40 +0000 (15:43 +0200)
commit88c54cdf61f508ebcf8da2d819f5dfc03e954d1d
treeef895c90efc68011841b0bbecc011b8fceb8926c
parent07b3b5e9ed807a0d2077319b8e43a42e941db818
ALSA: core: Fix unexpected error at replacing user TLV

When user tries to replace the user-defined control TLV, the kernel
checks the change of its content via memcmp().  The problem is that
the kernel passes the return value from memcmp() as is.  memcmp()
gives a non-zero negative value depending on the comparison result,
and this shall be recognized as an error code.

The patch covers that corner-case, return 1 properly for the changed
TLV.

Fixes: 8aa9b586e420 ("[ALSA] Control API - more robust TLV implementation")
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/control.c