]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mmc: sdhci: clarify the get_timeout_clock callback
authorShawn Lin <shawn.lin@rock-chips.com>
Fri, 24 Mar 2017 07:50:12 +0000 (15:50 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 24 Apr 2017 19:41:48 +0000 (21:41 +0200)
commit8cc35289227c5cbb8811048519c1703e2137d421
treee742bcdbf2b2229677f5abfec2eaf9924fff03b5
parentbd675698e8eece61c02a5e436e6d5d5ac1180e46
mmc: sdhci: clarify the get_timeout_clock callback

Currently the get_timeout_clock callback doesn't clearly
have a statement that it needs the variant drivers to return
the timeout clock rate in kHz if the SDHCI_TIMEOUT_CLK_UNIT
isn't present, otherwise the variant drivers should return it
in MHz. It's also very likely that further variant drivers which
are going to use this callback will be confused by this situation.
Given the fact that moderm sdhci variant hosts are very prone to get
the timeout clock from common clock framework (actually the only three
users did that), it's more natural to return the value in Hz and we
make an explicit comment there. Then we put the unit conversion inside
the sdhci core. Thus will improve the code and prevent further misuses.

Reported-by: Anssi Hannula <anssi.hannula@bitwise.fi>
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-cadence.c
drivers/mmc/host/sdhci-of-arasan.c
drivers/mmc/host/sdhci.c
drivers/mmc/host/sdhci.h