]> git.karo-electronics.de Git - karo-tx-linux.git/commit
irda: Correctly clean up self->ias_obj on irda_bind() failure.
authorDavid S. Miller <davem@davemloft.net>
Mon, 20 Sep 2010 00:56:19 +0000 (17:56 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 27 Sep 2010 00:21:16 +0000 (17:21 -0700)
commit8e75a0d65dce9d24b551d4a5ccbe00a23771583a
treeb13d5c1cef909f1964f7e97660e93607d356cd19
parent602b219309ced41c9787976230e5536c1796c720
irda: Correctly clean up self->ias_obj on irda_bind() failure.

[ Upstream commit 628e300cccaa628d8fb92aa28cb7530a3d5f2257 ]

If irda_open_tsap() fails, the irda_bind() code tries to destroy
the ->ias_obj object by hand, but does so wrongly.

In particular, it fails to a) release the hashbin attached to the
object and b) reset the self->ias_obj pointer to NULL.

Fix both problems by using irias_delete_object() and explicitly
setting self->ias_obj to NULL, just as irda_release() does.

Reported-by: Tavis Ormandy <taviso@cmpxchg8b.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/irda/af_irda.c