]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net: packet: fix information leak to userland
authorVasiliy Kulikov <segooon@gmail.com>
Wed, 10 Nov 2010 20:09:10 +0000 (12:09 -0800)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Sun, 17 Apr 2011 20:16:03 +0000 (16:16 -0400)
commit9812927a368cf5e7be0d060405ad45a17922db05
treee7139505b41e4fd9b310dce35af943c17cd3e97c
parentb900981f8676c3c7081fb4df0114eceecdfb5960
net: packet: fix information leak to userland

commit 67286640f638f5ad41a946b9a3dc75327950248f upstream

packet_getname_spkt() doesn't initialize all members of sa_data field of
sockaddr struct if strlen(dev->name) < 13.  This structure is then copied
to userland.  It leads to leaking of contents of kernel stack memory.
We have to fully fill sa_data with strncpy() instead of strlcpy().

The same with packet_getname(): it doesn't initialize sll_pkttype field of
sockaddr_ll.  Set it to zero.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
net/packet/af_packet.c