]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Input: synaptics - do not mix logical and bitwise operations
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 23 Mar 2017 17:02:50 +0000 (10:02 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 23 Mar 2017 21:49:37 +0000 (14:49 -0700)
commit996b9eedd061752bfa0f3a10381515d67db26b3e
treed8bc039cf364d2f5980a1ee9d8acc31eef82e706
parentcf5cd9d4480a87da78768718cac194a71079b5cb
Input: synaptics - do not mix logical and bitwise operations

Let's stop using !!x to reduce value of trackstick button expression to 0/1
and use shift instead. This removes the following sparse warning:

  CHECK   drivers/input/mouse/synaptics.c
drivers/input/mouse/synaptics.c:943:79: warning: dubious: !x | y

Also, the bits we are testing are not capabilities, so lets drop "_CAP"
suffix from macro names.

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/synaptics.c
drivers/input/mouse/synaptics.h