]> git.karo-electronics.de Git - karo-tx-linux.git/commit
isdn: avoid calling tty_ldisc_flush() in atomic context
authorTilman Schmidt <tilman@imap.cc>
Mon, 5 Jul 2010 14:18:27 +0000 (14:18 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 21 Mar 2011 19:45:53 +0000 (12:45 -0700)
commit99b0ee6c642cc2d03fc38dab8e64ae6ef468d3fe
tree7b3cebd501d845716908e7c82ac4273998f05c1e
parentb8f5defbad63b47b8a43e4e6cc6089b93049f87f
isdn: avoid calling tty_ldisc_flush() in atomic context

commit bc10f96757bd6ab3721510df8defa8f21c32f974 upstream.

Remove the call to tty_ldisc_flush() from the RESULT_NO_CARRIER
branch of isdn_tty_modem_result(), as already proposed in commit
00409bb045887ec5e7b9e351bc080c38ab6bfd33.
This avoids a "sleeping function called from invalid context" BUG
when the hardware driver calls the statcallb() callback with
command==ISDN_STAT_DHUP in atomic context, which in turn calls
isdn_tty_modem_result(RESULT_NO_CARRIER, ~), and from there,
tty_ldisc_flush() which may sleep.

Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/isdn/i4l/isdn_tty.c