]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ARM: tegra: irq: fix buggy usage of irq_data irq field
authorMarc Zyngier <marc.zyngier@arm.com>
Wed, 26 Nov 2014 17:55:31 +0000 (17:55 +0000)
committerArnd Bergmann <arnd@arndb.de>
Thu, 27 Nov 2014 13:01:55 +0000 (14:01 +0100)
commit9a343b9eb8c1f8db9dae804709a6578379a538f3
tree524bd793b8f74539cf474d16497a9b200b403d60
parent5d01410fe4d92081f349b013a2e7a95429e4f2c9
ARM: tegra: irq: fix buggy usage of irq_data irq field

The crazy gic_arch_extn thing that Tegra uses contains multiple
references to the irq field in struct irq_data, and uses this
to directly poke hardware register.

But irq is the *virtual* irq number, something that has nothing
to do with the actual HW irq (stored in the hwirq field). And once
we put the stacked domain code in action, the whole thing explodes,
as these two values are *very* different:

root@bacon-fat:~# cat /proc/interrupts
            CPU0       CPU1
 16:      25801       2075       GIC  29  twd
 17:          0          0       GIC  73  timer0
112:          0          0      GPIO  58  c8000600.sdhci cd
123:          0          0      GPIO  69  c8000200.sdhci cd
279:       1126          0       GIC 122  serial
281:          0          0       GIC  70  7000c000.i2c
282:          0          0       GIC 116  7000c400.i2c
283:          0          0       GIC 124  7000c500.i2c
284:        300          0       GIC  85  7000d000.i2c
[...]

Just replacing all instances of irq with hwirq fixes the issue.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
arch/arm/mach-tegra/irq.c