]> git.karo-electronics.de Git - karo-tx-linux.git/commit
[media] mx3-camera: locking cleanup in mx3_videobuf_queue()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 29 Aug 2013 08:23:36 +0000 (05:23 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Tue, 24 Sep 2013 16:33:55 +0000 (13:33 -0300)
commita7a69197a7e6aca22acdddef3f1bb691e239e6d1
tree983e47538096af0fbc87acb608771aec8e4f0d39
parent47c32ec9392a1fc7dec9d7cfde084e1432fcee82
[media] mx3-camera: locking cleanup in mx3_videobuf_queue()

Smatch complains about the locking here because we mix spin_lock_irq()
with spin_lock_irqsave() in an unusual way.  According to Smatch, it's
not always clear if the IRQs are enabled or disabled when we return.  It
turns out this function is always called with IRQs enabled and we can
just use spin_lock_irq().
It's called from __enqueue_in_driver().

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/platform/soc_camera/mx3_camera.c