]> git.karo-electronics.de Git - karo-tx-linux.git/commit
perf pmu: Fix check for unset alias->unit array
authorArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 15 Feb 2017 13:06:20 +0000 (10:06 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 15 Feb 2017 13:06:20 +0000 (10:06 -0300)
commitb30a7d1fc96d60fe2c02e375a56a046385701d17
tree38cfab671653991a5c6c925d5c9946c27acab8d9
parenta0b2f5af4c99d3da7ce9bc2b3b4641c8ffd22615
perf pmu: Fix check for unset alias->unit array

The alias->unit field is an array, so to check that it is not set we
should see if it is an empty string, i.e. alias->unit[0], instead of
checking alias->unit != NULL, as this will _always_ evaluate to 'true'.

Pointed out by clang.

Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20170214182435.GD4458@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/pmu.c