]> git.karo-electronics.de Git - karo-tx-linux.git/commit
isdn: fix information leak
authorDan Carpenter <error27@gmail.com>
Wed, 4 Aug 2010 23:38:06 +0000 (23:38 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 26 Aug 2010 23:45:59 +0000 (16:45 -0700)
commitb46ddc15f90dca13564f9c2be6210d7d9fef014b
tree0cb05dbc49abc06fbe4e0d4f3404ce0de8e733e0
parent1a1b1d29b0d472da80f23fc58885dc2151b62b72
isdn: fix information leak

[ Upstream commit 4b030d4288a569d6bdeca884d7f102d951f097f2 ]

The main motivation of this patch changing strcpy() to strlcpy().
We strcpy() to copy a 48 byte buffers into a 49 byte buffers.  So at
best the last byte has leaked information, or maybe there is an
overflow?  Anyway, this patch closes the information leaks by zeroing
the memory and the calls to strlcpy() prevent overflows.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/isdn/sc/ioctl.c