]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sysfs: make __sysfs_remove_dir() recursive
authorTejun Heo <tj@kernel.org>
Wed, 18 Sep 2013 21:15:37 +0000 (17:15 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Oct 2013 23:38:52 +0000 (16:38 -0700)
commitbcdde7e221a8750f9b62b6d0bd31b72ea4ad9309
treeb86620a59f4629804fc213430c2d2446d78f68b8
parent26ea12dec0c84133add937455be76d44fe253d85
sysfs: make __sysfs_remove_dir() recursive

Currently, sysfs directory removal is inconsistent in that it would
remove any files directly under it but wouldn't recurse into
directories.  Thanks to group subdirectories, this doesn't even match
with kobject boundaries.  sysfs is in the process of being separated
out so that it can be used by multiple subsystems and we want to have
a consistent behavior - either removal of a sysfs_dirent should remove
every descendant entries or none instead of something inbetween.

This patch implements proper recursive removal in
__sysfs_remove_dir().  The function now walks its subtree in a
post-order walk to remove all descendants.

This is a behavior change but kobject / driver layer, which currently
is the only consumer, has already been updated to handle duplicate
removal attempts, so nothing should be broken after this change.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/sysfs/dir.c