]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sfc: fix attempt to translate invalid filter ID
authorEdward Cree <ecree@solarflare.com>
Thu, 29 Jun 2017 15:50:06 +0000 (16:50 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Jun 2017 19:59:38 +0000 (15:59 -0400)
commitd58299a478c416c0b48e4b31c6332fe7beb63000
tree7e1c5c96244bdb703fae5368db5f9c146e05e427
parente44699d2c28067f69698ccb68dd3ddeacfebc434
sfc: fix attempt to translate invalid filter ID

When filter insertion fails with no rollback, we were trying to convert
 EFX_EF10_FILTER_ID_INVALID to an id to store in 'ids' (which is either
 vlan->uc or vlan->mc).  This would WARN_ON_ONCE and then record a bogus
 filter ID of 0x1fff, neither of which is a good thing.

Fixes: 0ccb998bf46d ("sfc: fix filter_id misinterpretation in edge case")
Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/ef10.c