]> git.karo-electronics.de Git - karo-tx-linux.git/commit
dmaengine: cppi41: More PM runtime fixes
authorTony Lindgren <tony@atomide.com>
Wed, 16 Nov 2016 18:24:15 +0000 (10:24 -0800)
committerVinod Koul <vinod.koul@intel.com>
Thu, 17 Nov 2016 10:39:23 +0000 (16:09 +0530)
commitd5afc1b68a6ddc27746d31f775025afe75ec8122
treef20ea6d2137c340c5233564f4de61380591676ed
parent740b4be3f742100ea66f0f9ee9715b10ee304a90
dmaengine: cppi41: More PM runtime fixes

Fix use of u32 instead of int for checking for negative errors values
as pointed out by Dan Carpenter <dan.carpenter@oracle.com>.

And while testing the PM runtime error path by randomly returning
failed values in runtime resume, I noticed two more places that need
fixing:

- If pm_runtime_get_sync() fails in probe, we still need to do
  pm_runtime_put_sync() to keep the use count happy. We could call
  pm_runtime_put_noidle() on the error path, but we're just going
  to call pm_runtime_disable() after that so pm_runtime_put_sync()
  will do what we want

- We should print an error if pm_runtime_get_sync() fails in
  cppi41_dma_alloc_chan_resources() so we know where it happens

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 740b4be3f742 ("dmaengine: cpp41: Fix handling of error path")
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/cppi41.c