]> git.karo-electronics.de Git - karo-tx-linux.git/commit
NFSv4.1: Return NFS4ERR_BADSESSION to callbacks during session resets
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Tue, 2 Aug 2011 18:46:52 +0000 (14:46 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 29 Aug 2011 20:29:08 +0000 (13:29 -0700)
commite25d2c749d25fc559f374766af66d267c97e0877
tree8f04bd2605641a7c887158aa8d149c36d74646d9
parentf4bc412bc2f46d644375403b601f42d8487949da
NFSv4.1: Return NFS4ERR_BADSESSION to callbacks during session resets

commit 910ac68a2b80c7de95bc8488734067b1bb15d583 upstream.

If the client is in the process of resetting the session when it receives
a callback, then returning NFS4ERR_DELAY may cause a deadlock with the
DESTROY_SESSION call.

Basically, if the client returns NFS4ERR_DELAY in response to the
CB_SEQUENCE call, then the server is entitled to believe that the
client is busy because it is already processing that call. In that
case, the server is perfectly entitled to respond with a
NFS4ERR_BACK_CHAN_BUSY to any DESTROY_SESSION call.

Fix this by having the client reply with a NFS4ERR_BADSESSION in
response to the callback if it is resetting the session.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/nfs/callback_proc.c