]> git.karo-electronics.de Git - karo-tx-linux.git/commit
gdth: integer overflow in ioctl
authorDan Carpenter <error27@gmail.com>
Fri, 8 Oct 2010 07:03:07 +0000 (09:03 +0200)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Thu, 6 Jan 2011 23:08:26 +0000 (18:08 -0500)
commite71740bf3ed9224a9f6e31e28a387cc23bbaa824
treedb20afb0fcedef32872ac3e6b1d8f93fdc3c26af
parent00c0012c32adebb709e8139ec603b476adae95ea
gdth: integer overflow in ioctl

commit f63ae56e4e97fb12053590e41a4fa59e7daa74a4 upstream.

gdth_ioctl_alloc() takes the size variable as an int.
copy_from_user() takes the size variable as an unsigned long.
gen.data_len and gen.sense_len are unsigned longs.
On x86_64 longs are 64 bit and ints are 32 bit.

We could pass in a very large number and the allocation would truncate
the size to 32 bits and allocate a small buffer.  Then when we do the
copy_from_user(), it would result in a memory corruption.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
drivers/scsi/gdth.c