]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Revert "serial/amba-pl011: Leave the TX IRQ alone when the UART is not open"
authorDave Martin <Dave.Martin@arm.com>
Fri, 8 May 2015 13:07:50 +0000 (14:07 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 9 May 2015 16:36:36 +0000 (18:36 +0200)
commitec61847855094d6f6144340b26f14203f25dd4e9
tree576e0407ff7ab1d5112cf94c7134e61f01c91ab1
parent66cf1d8473780fcb1a90e86fd19ba276520deb14
Revert "serial/amba-pl011: Leave the TX IRQ alone when the UART is not open"

This reverts commit f2ee6dfa0e8597eea8b98d240b0033994e20d215.

Jakub KiciƄski observed that this patch can cause the pl011
driver to hang if if the only process with a pl011 port open is
killed by a signal, pl011_shutdown() can get called with an
arbitrary amount of data still in the FIFO.

Calling _shutdown() with the TX FIFO non-empty is questionable
behaviour and my itself be a bug.

Since the affected patch was speculative anyway, and brings limited
benefit, the simplest course is to remove the assumption that TXIS
will always be left asserted after the port is shut down.

Signed-off-by: Dave Martin <Dave.Martin@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/amba-pl011.c