]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ARM: 6146/1: sa1111: Prevent deadlock in resume path
authorMarek Vašut <marek.vasut@gmail.com>
Wed, 26 May 2010 22:53:09 +0000 (23:53 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 5 Jul 2010 18:10:52 +0000 (11:10 -0700)
commitf26a43c5a1c7cf8f7c9c2007fbd0f1789df99db3
tree840c2d67d44088b0e51ca9b1d2a26a03f65368ff
parent1db9679a1567e1f0dc5d9103911f5cfd7eb493a9
ARM: 6146/1: sa1111: Prevent deadlock in resume path

commit 3defb2476166445982a90c12d33f8947e75476c4 upstream.

This patch reorganises the sa1111_resume() function in a manner the spinlock
happens after calling the sa1111_wake(). This fixes two bugs:

1) This function called sa1111_wake() which tried to claim the same spinlock
   the sa1111_resume() already claimed. This would result in certain deadlock.

   Original idea for this part: Russell King <rmk+kernel@arm.linux.org.uk>

2) The function didn't unlock the spinlock in case the chip didn't report
   correct ID.

   Original idea for this part: Julia Lawall <julia@diku.dk>

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/arm/common/sa1111.c