]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x86/dumpstack: Handle NULL stack pointer in show_trace_log_lvl()
authorJosh Poimboeuf <jpoimboe@redhat.com>
Thu, 17 Nov 2016 06:04:58 +0000 (00:04 -0600)
committerIngo Molnar <mingo@kernel.org>
Thu, 17 Nov 2016 06:48:39 +0000 (07:48 +0100)
commitf4474c9f0bba17857b1a47c8dc89c07a0845c2b2
tree57dc79aef94b80fe95c0a96f26908057ddc0b79d
parentadb402cd1461eef6e1a21db4532a3b9e6a6be853
x86/dumpstack: Handle NULL stack pointer in show_trace_log_lvl()

When show_trace_log_lvl() is called from show_regs(), it completely
fails to dump the stack.  This bug was introduced when
show_stack_log_lvl() was removed with the following commit:

  0ee1dd9f5e7e ("x86/dumpstack: Remove raw stack dump")

Previous callers of that function now call show_trace_log_lvl()
directly.  That resulted in a subtle change, in that the 'stack'
argument can now be NULL in certain cases.

A NULL 'stack' pointer means that the stack dump should start from the
topmost stack frame unless 'regs' is valid, in which case it should
start from 'regs->sp'.

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 0ee1dd9f5e7e ("x86/dumpstack: Remove raw stack dump")
Link: http://lkml.kernel.org/r/c551842302a9c222d96a14e42e4003f059509f69.1479362652.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/dumpstack.c