From: Lothar Waßmann Date: Wed, 14 Aug 2013 09:43:59 +0000 (+0300) Subject: usb: chipidea: ci_hdrc_imx: remove an unsolicited module_put() call from ci_hdrc_imx_... X-Git-Tag: next-20130822~28^2~34 X-Git-Url: https://git.karo-electronics.de/?p=karo-tx-linux.git;a=commitdiff_plain;h=769d92c411c3479835d2428edfd167c41d80c5f0 usb: chipidea: ci_hdrc_imx: remove an unsolicited module_put() call from ci_hdrc_imx_remove() This prevents the USB PHY refcount to be decremented below zero upon unloading the ci-hdrc-imx module. Signed-off-by: Lothar Waßmann Acked-by: Peter Chen Signed-off-by: Alexander Shishkin Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index a9a3bcf99dbf..005ad5f11b69 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hdrc_imx.c @@ -208,10 +208,8 @@ static int ci_hdrc_imx_remove(struct platform_device *pdev) if (data->reg_vbus) regulator_disable(data->reg_vbus); - if (data->phy) { + if (data->phy) usb_phy_shutdown(data->phy); - module_put(data->phy->dev->driver->owner); - } clk_disable_unprepare(data->clk);