From: Andrew Morton Date: Tue, 7 Apr 2015 23:57:05 +0000 (+1000) Subject: tomoyo-reduce-mmap_sem-hold-for-mm-exe_file-checkpatch-fixes X-Git-Tag: KARO-TXA5-2015-06-26~17^2~16 X-Git-Url: https://git.karo-electronics.de/?p=karo-tx-linux.git;a=commitdiff_plain;h=ad05ba9b2479b83bb7d088a4d443628844b47d5b tomoyo-reduce-mmap_sem-hold-for-mm-exe_file-checkpatch-fixes Sumeone needs to buy a tab key. WARNING: please, no spaces at the start of a line #29: FILE: security/tomoyo/util.c:951: + struct file *exe_file;$ WARNING: please, no spaces at the start of a line #30: FILE: security/tomoyo/util.c:952: + const char *cp;$ WARNING: please, no spaces at the start of a line #31: FILE: security/tomoyo/util.c:953: + struct mm_struct *mm = current->mm;$ WARNING: please, no spaces at the start of a line #40: FILE: security/tomoyo/util.c:955: + if (!mm)$ WARNING: suspect code indent for conditional statements (7, 15) #40: FILE: security/tomoyo/util.c:955: + if (!mm) + return NULL; WARNING: please, no spaces at the start of a line #42: FILE: security/tomoyo/util.c:957: + exe_file = get_mm_exe_file(mm);$ WARNING: please, no spaces at the start of a line #43: FILE: security/tomoyo/util.c:958: + if (!exe_file)$ WARNING: suspect code indent for conditional statements (7, 15) #43: FILE: security/tomoyo/util.c:958: + if (!exe_file) + return NULL; WARNING: please, no spaces at the start of a line #46: FILE: security/tomoyo/util.c:961: + cp = tomoyo_realpath_from_path(&exe_file->f_path);$ WARNING: please, no spaces at the start of a line #47: FILE: security/tomoyo/util.c:962: + fput(exe_file);$ WARNING: please, no spaces at the start of a line #48: FILE: security/tomoyo/util.c:963: + return cp;$ total: 0 errors, 11 warnings, 28 lines checked ./patches/tomoyo-reduce-mmap_sem-hold-for-mm-exe_file.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Davidlohr Bueso Cc: James Morris Cc: Tetsuo Handa Signed-off-by: Andrew Morton --- diff --git a/security/tomoyo/util.c b/security/tomoyo/util.c index 29f3b65284c7..b974a6997d7f 100644 --- a/security/tomoyo/util.c +++ b/security/tomoyo/util.c @@ -948,19 +948,19 @@ bool tomoyo_path_matches_pattern(const struct tomoyo_path_info *filename, */ const char *tomoyo_get_exe(void) { - struct file *exe_file; - const char *cp; - struct mm_struct *mm = current->mm; + struct file *exe_file; + const char *cp; + struct mm_struct *mm = current->mm; - if (!mm) - return NULL; - exe_file = get_mm_exe_file(mm); - if (!exe_file) - return NULL; + if (!mm) + return NULL; + exe_file = get_mm_exe_file(mm); + if (!exe_file) + return NULL; - cp = tomoyo_realpath_from_path(&exe_file->f_path); - fput(exe_file); - return cp; + cp = tomoyo_realpath_from_path(&exe_file->f_path); + fput(exe_file); + return cp; } /**