]> git.karo-electronics.de Git - karo-tx-linux.git/commit
usb: musb: finish suspend/reset work independently from musb_hub_control()
authorDaniel Mack <zonque@gmail.com>
Wed, 18 Dec 2013 19:23:46 +0000 (20:23 +0100)
committerFelipe Balbi <balbi@ti.com>
Thu, 19 Dec 2013 16:31:11 +0000 (10:31 -0600)
commit8ed1fb790ea24bb223e3b30e2b22bccf5b0a76c9
treeeaa291bdb62bc8773df7f62d760c8ecf6fa25a65
parent56b1b909d7afa5e0415363fafec3df0fc34b95c5
usb: musb: finish suspend/reset work independently from musb_hub_control()

Currently, resume and reset is completed when the USB core calls back
the root hub, asking for the port's state. This results in
unpredictable timing of state assertion, which in turn renders some
USB devices unusable after resume.

Fix this by moving the logic to end the reset and suspend state out of
musb_hub_control() into separate functions called from delayed workers.
GetPortStatus only reports the current state now, without taking any
real action.

The rh_timeout variable is kept in order to define a minimum time gap
between reset and resume only.

FWIW, in my case, a Verbatim "STORE N GO" mass storage device won't
resume cleanly without this patch.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/musb/musb_core.c
drivers/usb/musb/musb_core.h
drivers/usb/musb/musb_host.h
drivers/usb/musb/musb_virthub.c