]> git.karo-electronics.de Git - karo-tx-linux.git/commit
l2tp: cast l2tp traffic counter to unsigned
authorDominik Heidler <dheidler@suse.de>
Fri, 9 Jun 2017 14:29:47 +0000 (16:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 10 Jun 2017 20:14:27 +0000 (16:14 -0400)
commit9b3dc0a17d7388c4fb83736ca45253a93e994ce4
treecc7159facc65764464e11db20b9b605bb64ac6d7
parentd8dba51de5dfb55225b169653bbd7379ac0d0c63
l2tp: cast l2tp traffic counter to unsigned

This fixes a counter problem on 32bit systems:
When the rx_bytes counter reached 2 GiB, it jumpd to (2^64 Bytes - 2GiB) Bytes.

rtnl_link_stats64 has __u64 type and atomic_long_read returns
atomic_long_t which is signed. Due to the conversation
we get an incorrect value on 32bit systems if the MSB of
the atomic_long_t value is set.

CC: Tom Parkin <tparkin@katalix.com>
Fixes: 7b7c0719cd7a ("l2tp: avoid deadlock in l2tp stats update")
Signed-off-by: Dominik Heidler <dheidler@suse.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/l2tp/l2tp_eth.c