]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drm/i915: overlay on gen2 can't address above 1G
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 30 Aug 2010 19:25:23 +0000 (21:25 +0200)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 6 Sep 2010 22:09:52 +0000 (23:09 +0100)
commit9f82d23846146990d475f6753be733e55788d88d
tree9e9763c3c85c3a1e15be7b123ddd63d5a20efaac
parent300387c0b57d75e5218e2881d6ad2720657a8bcf
drm/i915: overlay on gen2 can't address above 1G

So set the coherent dma mask accordingly. This dma mask is only used
for physical objects, so it won't really matter allocation-wise.

Now this never really surfaced because sane 32bit kernels only have 1G
of lowmem. But some eager testers (distros?) still carry around the patch
to adjust lowmem via a kconfig option. And the kernel seems to favour
high allocations on boot-up, hence the overlay blowing up reliably.

Because the patch is tiny and nicely shows how broken gen2 is it's imho
worth to merge despite the fact that mucking around with the lowmem/
highmem division is (no longer) supported.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=28318
Cc: stable@kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/i915_dma.c